fix bug 977406 - exclude expired versions from front page graph #1920
Conversation
|
r? @peterbe |
There was a problem hiding this comment.
In case you're wondering, this code now picks the new "expired, featured" version I've added.. I am not sure if this is what's wanted for this report so adjusted the test. It may be that we want to adjust the code for that view though - wdyt?
There was a problem hiding this comment.
"expired, featured"? What's that?
There was a problem hiding this comment.
So the release is still marked as featured in the database, but it has expired (it's past its sunset_date in product_versions table, which is generally set in releases_raw by ftpscraper but can be manually manipulated)
There was a problem hiding this comment.
Although for the purposes of this test all you care about is that current versions service is returning a release that is both expired and also featured, which currently does happen (whether or not that is a bug is a valid question - I think it's probably OK but it's a bit sad-making)
|
@peterbe tests pass now :) |
|
r+ |
fix bug 977406 - exclude expired versions from front page graph
2 participants
No description provided.