Skip to content

fixes bug 1091039 - Upgrade to crontabber 0.15#2459

Merged
peterbe merged 2 commits into
mozilla-services:masterfrom
peterbe:bug-1091039-upgrade-to-crontabber-015
Oct 29, 2014
Merged

fixes bug 1091039 - Upgrade to crontabber 0.15#2459
peterbe merged 2 commits into
mozilla-services:masterfrom
peterbe:bug-1091039-upgrade-to-crontabber-015

Conversation

@peterbe
Copy link
Copy Markdown
Contributor

@peterbe peterbe commented Oct 29, 2014

@peterbe
Copy link
Copy Markdown
Contributor Author

peterbe commented Oct 29, 2014

@rhelmer I guess the key thing to test/verify is that you're able to do the setup.py develop with this version.

Comment thread requirements.txt Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need spaces like:

# sha 256: 5dFhnMcB4H5GhM-hUsM4RKf3noEAQB1B_Z4MBV-PYjg

Otherwise peep complains that the sha is missing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the problem is the space between sha and 256

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. I wrote a tool to do it and clearly it wasn't doing it right. Fixed now
https://gist.github.com/34f28872455ec8f34a63

@rhelmer
Copy link
Copy Markdown
Contributor

rhelmer commented Oct 29, 2014

r+ with the sha256 lines fixed so peep is happy - I did that and now python setup.py develop WFM.

peterbe pushed a commit that referenced this pull request Oct 29, 2014
…er-015

fixes bug 1091039 - Upgrade to crontabber 0.15
@peterbe peterbe merged commit fabf225 into mozilla-services:master Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants