Fix applySourceMap's aSourceMapPath parameter source content support #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set source content with relation to aSourceMapPath in SourceMapGenerator#applySourceMap. Before, in the related test, `../coffee/foo.coffee`'s source content would be placed at `../coffee/foo.coffee` instead of where it should be at `coffee/foo.coffee` derived maps. Not being stored at that location it was left out of the generated map.
Contributor
|
Nice catch! LGTM. |
|
Plus one. |
Contributor
|
ping |
|
@fitzgen Please, can you take a look at this? Merging this would make a lot of people happy downstream. |
|
any updates? |
Contributor
|
Hey sorry, I've been pretty focused on other work, will look at this soon. |
Contributor
|
Looks good, thanks! Sorry again about the delay. |
fitzgen
added a commit
that referenced
this pull request
Jun 2, 2014
Fix applySourceMap's aSourceMapPath parameter source content support
Contributor
Author
|
😄 |
|
Thanks @fitzgen for reacting favorably to my tweet. ;) |
Contributor
|
Not published yet. I was hoping to get a few of the other PRs merged as well and do it in one fell swoop. Will add a todo item to my list and if the other PRs don't get merged by the time I get to it I'll just publish anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While improving gruntjs/grunt-contrib-concat#59 after @lydell's insight to use the third parameter of
SourceMapGenerator#applySourceMapI noticed thesourcesContentwas not being honored in my test cases.sourcesContentwould be present, but the array was allnullvalues. To fix that, I have added a small branch similar to that in thethis._mappings.forEachblock inapplySourceMap. To test it, I modified the related test for the second and third parameter ofapplySourceMapto test if it is supportingsourcesContent.