Update documentation to note basis of lines and columns #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
approved these changes
Sep 22, 2017
Member
gregtatum
left a comment
gregtatum
left a comment
There was a problem hiding this comment.
Thank you for being verbose on this.
This changes the documentation to note that line numbers are 1-based and columns numbers are 0-based. I went with the verbose approach of updating every spot I could find that mentions lines or columns; thinking that this is preferable to maybe missing the information. Fixes mozilla#118
tromey
force-pushed
the
document-offsets
branch
from
9d2f2b5 to
0ef74c3
Compare
Contributor
Author
|
Had to rebase for the dist/ changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the documentation to note that line numbers are 1-based and
columns numbers are 0-based. I went with the verbose approach of
updating every spot I could find that mentions lines or columns;
thinking that this is preferable to maybe missing the information.
Fixes #118