Issue #227 #280
Merged
Issue #227 #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Dang it, those patches shouldn't be there. |
gregtatum
approved these changes
Sep 22, 2017
Member
gregtatum
left a comment
gregtatum
left a comment
There was a problem hiding this comment.
I agree with your fix for this, but I would also think carefully about how this change affects our end users on npm, as this technically requires a major version bump since the output here is subtly different.
test/test-source-map-consumer.js
Outdated
| assert.equal(i, 1); | ||
| }; | ||
|
|
||
| exports['test from issue 227'] = function (assert) { |
Member
There was a problem hiding this comment.
I would appreciate a little more verbosity on the test name. test non-normalized sourceRoot values (from issue #227).
| sourceRoot: './src/', | ||
| sourcesContent: [ 'var name = "Mark"\n' ] | ||
| }); | ||
| consumer.sourceContentFor(consumer.sources[0]); |
Member
There was a problem hiding this comment.
I'd also like to see an assertion for the new behavior you've introduced here, since the output will not be exactly the same.
assert.equal(consumer.sourceRoot, 'src/');
This calls normalize on the provided sourceRoot in BasicSourceMapConsumer. This allows a funny sourceRoot like "./src". Fixes mozilla#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.