Skip to content

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Jan 8, 2018

Closes #1187

@rpl
Copy link
Member

rpl commented Jan 8, 2018

@kumar303 it looks that flow 0.63.1 is smarter and it is now complaining that we were "lying" in the fake test helper :-)

I propose to workaround the issue by using an additional $FLOW_IGNORE, similarly to the one we are already using to stop flow from complaining about the fake function type signature:

@kumar303
Copy link
Contributor Author

kumar303 commented Jan 8, 2018

Maybe this would work? I haven't tried it yet.

export function fake<T>(...): $Shape<T>

I have a feeling it won't work though because things like Object.keys() tend to confuse Flow easily.

I am fine with a $FLOW_IGNORE comment too.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d4615b7 on greenkeeper/flow-bin-0.63.1 into d16f9c0 on master.

@kumar303 kumar303 merged commit d6aad9a into master Jan 9, 2018
@kumar303 kumar303 deleted the greenkeeper/flow-bin-0.63.1 branch January 9, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants