Skip to content

fix: Change Android cleanup message on exit #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2018
Merged

fix: Change Android cleanup message on exit #1201

merged 1 commit into from
Jan 9, 2018

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Jan 9, 2018

I think this can be a hidden debug message. What do you think?

@kumar303 kumar303 requested a review from rpl January 9, 2018 20:06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1fb6aa9 on kumar303:android-message into d6aad9a on mozilla:master.

rpl
rpl approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, there should not be any real reason to show it to the users by default.

@kumar303 kumar303 merged commit 05972a8 into mozilla:master Jan 9, 2018
@kumar303 kumar303 deleted the android-message branch January 9, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpl rpl rpl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumar303 @coveralls @rpl