-
Notifications
You must be signed in to change notification settings - Fork 366
fix: Ensured navigator.webdriver != true in launched Chromium
#3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensured navigator.webdriver != true in launched Chromium
#3553
Conversation
|
@Rob--W -- thanks for the review and the link to the issue, I hadn't realised that this is a known issue. Without |
Even without
The For this and other alternatives that I considered, see #3388 (comment) |
31156d9 to
b9c0705
Compare
b9c0705 to
4e1ac19
Compare
|
@Rob--W -- I removed the Not sure why the dependency audit is failing, I didn't change any dependencies. |
Rob--W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
4e1ac19 to
868a3f1
Compare
|
@Rob--W -- Thanks for the suggestions, I've committed those now. |
The `--remote-debugging-pipe` flag causes `navigator.webdriver == true` in the launched Chromium instance (provided there is no existing Chromium instance). The `--disable-blink-features=AutomationControlled` flag needs to be passed to prevent this and avoid breaking websites with bot detection features.
868a3f1 to
50fe713
Compare
Rob--W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as approved to clearly signal that the current shape of the patch looks good to me. In a comment I suggested a way to improve test coverage further, but it is not required for merging.
I'll let another team member do the actual merge and release since I am travelling.
The
--remote-debugging-pipeflag causesnavigator.webdriver == truein the launched Chromium instance (provided there is no existing Chromium instance). Flags need to be added to prevent this, otherwise many websites with bot detection features are broken.Fixes #3511