Bug 1169173: Empty emails for overdue requests

Author: globau

extensions/RequestNagger/bin/send-request-nags.pl

@@ -76,6 +76,7 @@
 sub send_nags {
     my (%args)   = @_;
     my $requests = {};
+    my $watching = $args{template} eq 'watching';
 
     # get requests
 
@@ -121,13 +122,15 @@ sub send_nags {
                     @{ $rh->{types}->{$report} }
                 );
 
-                # remove links to reports with too many items to display
-                my $total = 0;
-                foreach my $type (@{ $rh->{types}->{$report} }) {
-                    $total += scalar(@{ $rh->{$report}->{$type} });
-                }
-                if ($total > MAX_SETTER_COUNT) {
-                    $rh->{types}->{$report} = [];
+                if ($watching && $report eq 'setter') {
+                    # remove links to reports with too many items to display
+                    my $total = 0;
+                    foreach my $type (@{ $rh->{types}->{$report} }) {
+                        $total += scalar(@{ $rh->{$report}->{$type} });
+                    }
+                    if ($total > MAX_SETTER_COUNT) {
+                        $rh->{types}->{$report} = [];
+                    }
                 }
             }
         }

extensions/RequestNagger/template/en/default/account/prefs/request_nagging.html.tmpl

@@ -45,7 +45,8 @@
   [% END %]
 </p>
 
-<p>Add users to my watch list (comma separated list):
+<p>
+  Add users to my watch list (comma separated list):<br>
   [% INCLUDE global/userselect.html.tmpl
      id       => "add_watching"
      name     => "add_watching"