restrict homescreen submission to FxOS only (bug 1218574)

Author: Allen Short

mkt/submit/forms.py

@@ -164,6 +164,7 @@ def __init__(self, *args, **kw):
         kw.pop('request', None)
         self.addon = kw.pop('addon', None)
         self._is_packaged = kw.pop('is_packaged', False)
+        self.is_homescreen = False
         super(NewWebappVersionForm, self).__init__(*args, **kw)
 
     def clean(self):
@@ -201,6 +202,8 @@ def clean(self):
                 if self.addon and origin != self.addon.app_domain:
                     errors.append(_('Changes to "origin" are not allowed.'))
 
+            self.is_homescreen = pkg.get('role') == 'homescreen'
+
             if errors:
                 self._errors['upload'] = self.error_class(errors)
                 return
@@ -223,7 +226,8 @@ def is_packaged(self):
 class NewWebappForm(DeviceTypeForm, NewWebappVersionForm):
     ERRORS = DeviceTypeForm.ERRORS.copy()
     ERRORS['user'] = _lazy('User submitting validation does not match.')
-
+    ERRORS['homescreen'] = _lazy('Homescreens can only be submitted for '
+                                 'Firefox OS.')
     upload = forms.ModelChoiceField(
         widget=forms.HiddenInput,
         queryset=FileUpload.objects.filter(valid=True),
@@ -252,6 +256,8 @@ def clean(self):
             if not (upload.user and upload.user.pk == self.request.user.pk):
                 self._add_error('user')
 
+            if self.is_homescreen and self.get_devices() != [mkt.DEVICE_GAIA]:
+                self._add_error('homescreen')
         return data
 
     def is_packaged(self):

mkt/submit/tests/test_forms.py

@@ -124,6 +124,27 @@ def test_packaged_allowed_everywhere(self):
             assert form.is_valid(), form.errors
             assert form.is_packaged()
 
+    @mock.patch('mkt.submit.forms.parse_addon',
+                lambda *args: {'version': None, 'role': 'homescreen'})
+    def test_homescreen_device(self):
+        form = forms.NewWebappForm({'upload': self.file.uuid,
+                                    'free_platforms': ['free-firefoxos'],
+                                    'packaged': True},
+                                   request=self.request)
+        assert form.is_valid()
+
+    @mock.patch('mkt.submit.forms.parse_addon',
+                lambda *args: {'version': None, 'role': 'homescreen'})
+    def test_homescreen_wrong_device(self):
+        form = forms.NewWebappForm({'upload': self.file.uuid,
+                                    'free_platforms': ['free-firefoxos',
+                                                       'free-desktop'],
+                                    'packaged': True},
+                                   request=self.request)
+        assert not form.is_valid()
+        eq_(form.ERRORS['homescreen'], form.errors['free_platforms'])
+        eq_(form.ERRORS['homescreen'], form.errors['paid_platforms'])
+
 
 class TestNewWebappVersionForm(mkt.site.tests.TestCase):