Updated sign_apps mgmt command to only sign public (bug 840777)

Author: Rob Hudson

mkt/webapps/management/commands/sign_apps.py

@@ -5,9 +5,10 @@
 
 from celery.task.sets import TaskSet
 
-import addons.models
+import amo
+from addons.models import Webapp
 from lib.crypto.packaged import sign
-from mkt.webapps.models import Webapp
+
 
 HELP = """\
 Start tasks to re-sign web apps.
@@ -19,6 +20,7 @@
 If omitted, all signed apps will be re-signed.
 """
 
+
 log = logging.getLogger('z.addons')
 
 
@@ -27,12 +29,12 @@ class Command(BaseCommand):
         make_option('--webapps',
                     help='Webapp ids to process. Use commas to separate '
                          'multiple ids.'),
-        )
+    )
 
     help = HELP
 
     def handle(self, *args, **kw):
-        qs = Webapp.objects.filter(is_packaged=True)
+        qs = Webapp.objects.filter(is_packaged=True, status=amo.STATUS_PUBLIC)
         if kw['webapps']:
             pks = [int(a.strip()) for a in kw['webapps'].split(',')]
             qs = qs.filter(pk__in=pks)

mkt/webapps/tests/test_crons.py

@@ -111,6 +111,10 @@ def setUp(self):
             name='Mozillaball ょ', app_slug='test',
             is_packaged=True, version_kw={'version': '1.0',
                                           'created': None})
+        self.app3 = amo.tests.app_factory(
+            name='Test app 3', app_slug='test3', status=amo.STATUS_REJECTED,
+            is_packaged=True, version_kw={'version': '1.0',
+                                          'created': None})
 
     def test_by_webapp(self, sign_mock):
         v1 = self.app.get_version()
@@ -125,9 +129,10 @@ def test_all(self, sign_mock):
         call_command('sign_apps')
         file1 = v1.all_files[0]
         file2 = v2.all_files[0]
+        eq_(len(sign_mock.mock_calls), 2)
         sign_mock.assert_has_calls([
             mock.call(file1.file_path,
                       file1.signed_file_path, False),
             mock.call(file2.file_path,
                       file2.signed_file_path, False)],
-        any_order=True)
+            any_order=True)