Revert @ednapirahna's newsletter stuff

Author: mattbasta

media/css/ecosystem/landing.less

@@ -145,90 +145,6 @@
             }
         }
     }
-
-    #newsletter-signup {
-        .border-wrapper;
-        background: @white url(../../img/ecosystem/newsletter-arrow.png) no-repeat 320px 50%;
-        clear: both;
-        float: left;
-        width: 100%;
-
-        .form-title, .form-icons, .form-data, .form-details {
-            float: left;
-        }
-
-        .form-title {
-            margin-right: 80px;
-            width: 300px;
-
-            h3 {
-                background: url(../../img/ecosystem/loop.png) no-repeat 0 8px;
-                font-size: 32px;
-                line-height: 35px;
-                padding-left: 45px;
-            }
-
-            p {
-                font-size: 18px;
-                line-height: 22px;
-            }
-        }
-
-        .form-icons {
-            margin-right: 20px;
-            width: 240px;
-
-            p {
-                float: left;
-                font-size: 12px;
-                line-height: 15px;
-                padding: 0 5px;
-                text-align: center;
-                width: 70px;
-            }
-        }
-
-        .form-data {
-            width: 270px;
-
-            input[type="text"] {
-                width: 270px;
-            }
-
-            .form-details {
-                margin-top: 5px;
-
-                small {
-                    display: inline-block;
-                    float: right;
-                    font-size: 12px;
-                    line-height: 15px;
-                    margin-bottom: 10px;
-                    width: 250px;
-                }
-            }
-
-        }
-
-        #footer-email-errors, #footer-email-success {
-            float: right;
-            padding: 10px 20px 0;
-        }
-
-        form {
-            display: block;
-            float: left;
-            padding: 5px 25px;
-
-            .button {
-                background: #5ab045;
-                display: block;
-                font-size: 15px;
-                margin: 0 auto;
-                min-width: 150px;
-            }
-        }
-    }
 }
 
 #landing-page .half {

media/img/ecosystem/loop.png

@@ -825,16 +825,6 @@ def save(self):
         self.instance.save()
 
 
-class DevNewsletterForm(happyforms.Form):
-    """Devhub newsletter subscription form."""
-    email = forms.EmailField(
-        error_messages={'required':
-                        _lazy(u'Please enter a valid email address.')})
-    privacy = forms.BooleanField(
-        error_messages={'required':
-                        _lazy(u'You must agree to the Privacy Policy.')})
-
-
 class AppFormTechnical(addons.forms.AddonFormBase):
     developer_comments = TransField(widget=TransTextarea, required=False)
     flash = forms.BooleanField(required=False)

media/img/ecosystem/newsletter-arrow.png

@@ -1,6 +1,5 @@
 from django.conf import settings
 
-import basket
 import mock
 from nose.tools import eq_
 from pyquery import PyQuery as pq
@@ -42,33 +41,6 @@ def test_tutorials_refresh_disabled(self, mock_):
         self.client.get(self.url, {'refresh': '1'})
         assert not mock_.called
 
-    @mock.patch('basket.subscribe')
-    def test_newsletter_form_valid(self, subscribe_mock):
-        d = {'email': 'a@b.cd', 'privacy': True}
-        r = self.client.post(self.url, d)
-        self.assert3xx(r, reverse('ecosystem.landing'))
-        assert subscribe_mock.called
-
-    @mock.patch('basket.subscribe')
-    def test_newsletter_form_invalid(self, subscribe_mock):
-        d = {'email': '', 'privacy': True}
-        r = self.client.post(self.url, d)
-        eq_(r.status_code, 200)
-        self.assertFormError(r, 'newsletter_form', 'email',
-                             [u'Please enter a valid email address.'])
-        assert not subscribe_mock.called
-
-    @mock.patch('basket.subscribe')
-    def test_newsletter_form_exception(self, subscribe_mock):
-        subscribe_mock.side_effect = basket.BasketException
-        d = {'email': 'a@b.cd', 'privacy': True}
-        r = self.client.post(self.url, d)
-        eq_(r.status_code, 200)
-        eq_(pq(r.content)('.notification-box.error h2').text(),
-                          'We apologize, but an error occurred in our '
-                          'system. Please try again later.')
-        assert subscribe_mock.called
-
 
 class TestDevHub(amo.tests.TestCase):
 

media/img/ecosystem/newsletter-doc.png

@@ -1,15 +1,11 @@
 from django.conf import settings
 from django.http import Http404
-from django.shortcuts import get_object_or_404, redirect
+from django.shortcuts import get_object_or_404
 
-import basket
 import commonware.log
 import jingo
-from session_csrf import anonymous_csrf
 from tower import ugettext as _
 
-from amo import messages
-from mkt.developers.forms import DevNewsletterForm
 from mkt.ecosystem.tasks import refresh_mdn_cache
 from mkt.site import messages
 
@@ -29,7 +25,6 @@ def _refresh_mdn(request):
             ' Thanks for all your awesome work! Devs appreciate it!')
 
 
-@anonymous_csrf
 def landing(request):
     """Developer Hub landing page."""
     _refresh_mdn(request)
@@ -56,24 +51,8 @@ def landing(request):
             'path': 'FirefoxMarketplace_box-BR-RC-SD1%20640'
         }
     ]
-
-    form = DevNewsletterForm(request.POST or None)
-
-    if request.method == 'POST' and form.is_valid():
-        data = form.cleaned_data
-
-        try:
-            basket.subscribe(data['email'],
-                             'app-dev',
-                             source_url=settings.SITE_URL)
-            messages.success(request, _('Thank you for subscribing!'))
-            return redirect('ecosystem.landing')
-        except basket.BasketException:
-            messages.error(request, _('We apologize, but an error '
-                 'occurred in our system. Please try again later.'))
-
     return jingo.render(request, 'ecosystem/landing.html',
-           {'videos': videos, 'newsletter_form': form})
+           {'videos': videos})
 
 
 def support(request):

media/img/ecosystem/newsletter-nametag.png

@@ -2,7 +2,6 @@ amqplib==1.0.2
 anyjson==0.3.3
 argparse==1.2.1
 babel==0.9.6
-basket-client==0.3.1
 bleach==1.1.5
 cef==0.5
 celery==2.5.1