-
Notifications
You must be signed in to change notification settings - Fork 10
Update PR #34 to be compatible with cleanup branch #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
19
commits into
main
Choose a base branch
from
copilot/cleanup-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idget Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Apply isort to all Python files in kivy_matplotlib_widget package
# Conflicts: # kivy_matplotlib_widget/tools/interactive_converter.py # kivy_matplotlib_widget/uix/hover_widget.py # kivy_matplotlib_widget/uix/minmax_widget.py # kivy_matplotlib_widget/uix/navigation_bar_widget.py
Clean all trailing whitespace from Python source files
Applied isort with --profile black to ensure import ordering matches PEP8 standards while maintaining compatibility with black formatter. This resolves conflicts with cleanup branch which also applied isort.
Resolved conflicts by keeping the PEP8-formatted versions from the format branch. The format branch includes: - Comprehensive PEP8 formatting with black and autopep8 - Proper import ordering with isort (--profile black) - Consistent code style throughout This supersedes the isort and trailing whitespace changes from cleanup branch while ensuring full PEP8 compliance.
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Co-authored-by: mp-007 <19823482+mp-007@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update branch for cleanup purposes
Update PR #34 to be compatible with cleanup branch
Oct 22, 2025
Copilot finished work on behalf of
mp-007
October 22, 2025 16:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the PEP8 formatting changes from PR #34 to be compatible with the latest changes in the
cleanupbranch, resolving merge conflicts and making it ready to merge.Problem
PR #34 was not mergeable into the
cleanupbranch because:Solution
This PR incorporates the latest changes from the cleanup branch while preserving the comprehensive PEP8 formatting:
Applied isort with black profile: Re-ran isort with
--profile blackon all Python files to ensure import ordering matches both black formatter standards and the cleanup branch's requirements.Merged cleanup branch: Successfully merged the latest cleanup branch changes, resolving conflicts by keeping the superior PEP8-formatted versions that include:
Preserved formatting quality: All the PEP8 improvements from PR Format all Python files in kivy_matplotlib_widget to be PEP8 compliant #34 are maintained:
Verification
Impact
This PR enables the PEP8 formatting work from PR #34 to be merged into the cleanup branch, improving code quality and consistency across the entire codebase while maintaining 100% backward compatibility.
Files Modified
All files from PR #34 (21 files total):
__init__.py,factory_registers.py,icon_definitions.pyclipboard_tool.py,cursors.py,interactive_converter.py,pick_info.py.flake8(new file)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.