Sort headers when serializing to allow for headless JWT. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers are usually small so this should not significantly impact performance. Testing both equality between two serialized values (fails on 3.6+ only) and equality with expected serialized JSON, which fails on pre 3.6 too.
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 14 14
Lines 1065 1065
=======================================
Hits 1028 1028
Misses 37 37
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 14 14
Lines 1071 1071
=======================================
Hits 1034 1034
Misses 37 37
Continue to review full report at Codecov.
|
|
Merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers are usually small so this should not significantly impact
performance. Testing both equality between two serialized values (fails
on 3.6+ only) and equality with expected serialized JSON, which fails on pre 3.6
too.
This fixes #80 and is a less intrusive change than #81.