-
Notifications
You must be signed in to change notification settings - Fork 256
Fix deprecation warning from cryptography_backend.py #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning from cryptography_backend.py #222
Conversation
|
+1 to this, though I feel like this might break |
|
int_from_bytes is a python 2.x compatibility method, which is thankfully now EoL. int.from_bytes/to_bytes were added in python 3.2 about a decade ago. |
|
it's probably worth updating the calls to int_to_bytes also which will cause the same warning. |
|
see #207 |
|
Ah excellent, I had not seen that PR. 👍🏻 |
|
Is there any info on when this PR is going to be merged? |
|
I won't have time for at least another month. I highly recommend that at least one person on this thread ask @mpdavis to also become a maintainer. |
|
I am willing to become a maintainer so that some of the trivial, stale PRs/issues can be solved. How do I sign up? |
|
#229 is now merged, I figured it would be faster than rebasing this PR so I cherry-picked the commit, PR'ed it and merged. |
Based on `feature/backend-authorization` branch. Compare against that for a proper diff. - create API endpoint `posts` for submitting posts - add test user credentials to settings - provide `create` and `set_author` functions to CRUD class - refine models and schemas for posts - add tests for submitting posts - simplify tests and improve test isolation - provide dependency override for authorization during tests - add `pytest` config to `pyproject.toml` to ignore the deprecation warning from `python-jose` (issue is known and [fixed](mpdavis/python-jose#222), will be in next release) Related work items: #56
More info in #221