Skip to content

Conversation

@ibrag8998
Copy link
Contributor

More info in #221

@cbetta
Copy link

cbetta commented Apr 13, 2021

+1 to this, though I feel like this might break python-jose with older versions of cryptography. Depending on when this change was introduced to cryptography (and the python versions python-jose wants to support) it might be wiser to try the one method and then fall back onto the other?

@danielknell
Copy link

int_from_bytes is a python 2.x compatibility method, which is thankfully now EoL.

int.from_bytes/to_bytes were added in python 3.2 about a decade ago.

@danielknell
Copy link

it's probably worth updating the calls to int_to_bytes also which will cause the same warning.

@chitopunk
Copy link

see #207

@cbetta
Copy link

cbetta commented Apr 14, 2021

Ah excellent, I had not seen that PR. 👍🏻

@MasterSergius
Copy link

Is there any info on when this PR is going to be merged?

@blag
Copy link
Contributor

blag commented Apr 28, 2021

I won't have time for at least another month.

I highly recommend that at least one person on this thread ask @mpdavis to also become a maintainer.

@alanyee
Copy link

alanyee commented Apr 28, 2021

I am willing to become a maintainer so that some of the trivial, stale PRs/issues can be solved. How do I sign up?

@blag
Copy link
Contributor

blag commented Apr 28, 2021

@alanyee

ask @mpdavis to also become a maintainer.

@asherf
Copy link
Collaborator

asherf commented Apr 29, 2021

#229 is now merged, I figured it would be faster than rebasing this PR so I cherry-picked the commit, PR'ed it and merged.
thanks for the fix!

@asherf asherf closed this May 1, 2021
dasmerlon pushed a commit to dasmerlon/Schreddit that referenced this pull request Jan 11, 2022
Based on `feature/backend-authorization` branch. Compare against that for a proper diff.

- create API endpoint `posts` for submitting posts
- add test user credentials to settings
- provide `create` and `set_author` functions to CRUD class
- refine models and schemas for posts
- add tests for submitting posts
- simplify tests and improve test isolation
- provide dependency override for authorization during tests
- add `pytest` config to `pyproject.toml` to ignore the deprecation warning from `python-jose` (issue is known and [fixed](mpdavis/python-jose#222), will be in next release)

Related work items: #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants