Update javascript request example to fetch api #332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @n1arash thanks for the PR! The build is failing, though. You need to update the test fixtures to also use |
Author
|
@shalvah i'll fix this as soon as possible |
shalvah
suggested changes
Sep 22, 2018
| } | ||
| method: "GET", | ||
| credentials: "include", | ||
| headers |
Contributor
There was a problem hiding this comment.
Why did you remove the comma? The build's failing.
| language_tabs: | ||
| - bash | ||
| - javascript | ||
| - bash |
Contributor
There was a problem hiding this comment.
Any reason for these indentation changes? They're causing the build to fail.
Author
There was a problem hiding this comment.
i think That was Prettier Auto formatting
i'll fix them ASAP
| - javascript | ||
|
|
||
| includes: | ||
| ? includes |
Contributor
|
Hey @n1arash still doing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #330