Feat+Refactor: Introduce a wrapper for scalar values and refactor with it #4
+240
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Breaking Changes
InvalidArgumentExceptioninstead ofPDOExceptionwithout running queries.public function testAssigningNullThrowsExceptionOnNative(): void { - $this->expectException(PDOException::class); - $this->expectExceptionMessage("SQLSTATE[42000]: Syntax error or access violation: 1231 Variable 'foreign_key_checks' can't be set to the value of 'NULL'"); + $this->expectException(InvalidArgumentException::class); + $this->expectExceptionMessage('The value must be a scalar or Mpyw\LaravelMySqlSystemVariableManager\ValueInterface instance.'); $this->onNativeConnection(function (MySqlConnection $db) { $db->setSystemVariable('foreign_key_checks', null); $db->getPdo(); }); } public function testAssigningNullThrowsExceptionOnEmulation(): void { - $this->expectException(PDOException::class); - $this->expectExceptionMessage("SQLSTATE[42000]: Syntax error or access violation: 1231 Variable 'foreign_key_checks' can't be set to the value of 'NULL'"); + $this->expectException(InvalidArgumentException::class); + $this->expectExceptionMessage('The value must be a scalar or Mpyw\LaravelMySqlSystemVariableManager\ValueInterface instance.'); $this->onEmulatedConnection(function (MySqlConnection $db) { $db->setSystemVariable('foreign_key_checks', null); $db->getPdo(); }); }InvalidArgumentExceptioneven if the PDO connection is not established.