Skip to content

Conversation

@scarry1992
Copy link
Contributor

Hi. We've implemented the MQTT 5.0 support. Please have a look and merge if it's OK. We will also make similar pull-requests to mqtt-connection and MQTTJS repos.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the impressive and high quality work. Would you like to help maintaining this (and the other libraries) going forward?

Do you think we should release this in a minor release or in a major?

@scarry1992
Copy link
Contributor Author

HI, thanks for approving my commit. I would like to help maintaining all libraries as free time. I think, we should release all libraries as major version, despite the fact that the api is not breaking.

@mcollina mcollina merged commit 81cea4d into mqttjs:master Jun 3, 2018
@mcollina
Copy link
Member

mcollina commented Jun 3, 2018

Feel free to send a PR adding yourself in the README and package.json of this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants