Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Geometry => BufferGeometry #13427

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Conversation

WestLangley
Copy link
Collaborator

I modified webgl_trails.html slightly, but the other examples should be visually identical.

I am not able to test webvr_vive_dragging.html, but the changes are minimal.

@WestLangley
Copy link
Collaborator Author

Yikes! Both versions of webgl_trails are broken on macOS Safari -- at least on my machine. Looks like a strobe light... OK on macOS Chrome.

@looeee
Copy link
Collaborator

looeee commented Feb 25, 2018

The examples now look very different for me, on windows 10. Tested with Chrome and Firefox. Is this intentional?

OLD:
webgl_trails_old

NEW:
webgl_trails_new

@WestLangley
Copy link
Collaborator Author

Yes, it was intentional to make the dots bigger and decrease the number of lines generated so the trails are more visible.

I will change it there is an objection.

screen shot 2018-02-25 at 12 43 25 am

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 25, 2018

Both versions of webgl_trails are broken on macOS Safari

Same here. Looks like setting preserveDrawingBuffer to true causes the visual error.

@looeee
Copy link
Collaborator

looeee commented Feb 25, 2018

The old version was beautiful, the new one not so much, although it does arguably demonstrate what's happening more clearly. I'm not going to complain if the change is kept, but I do prefer the old one.

@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2018

The old version was beautiful, the new one not so much

I like both versions. But I'll probably update the example to something more... demonstrative?

@mrdoob mrdoob added this to the r91 milestone Feb 25, 2018
@mrdoob mrdoob merged commit 1c9cba9 into mrdoob:dev Feb 25, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2018

Thanks!

@WestLangley WestLangley deleted the dev-to_bg_3 branch February 25, 2018 19:32
@mrdoob
Copy link
Owner

mrdoob commented Feb 26, 2018

@grorg @kenrussell Any ideas why this example blinks in Safari?
https://rawgit.com/mrdoob/three.js/dev/examples/webgl_trails.html

@grorg
Copy link
Contributor

grorg commented Feb 26, 2018

Ouch! I don't know what's up.

I filed: https://bugs.webkit.org/show_bug.cgi?id=183151

I guess I broke preserveDrawingBuffer :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants