EXRLoader: bug fixes #13825
Merged
EXRLoader: bug fixes #13825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
requested changes
Apr 11, 2018
| @@ -839,6 +839,10 @@ THREE.EXRLoader.prototype._parser = function ( buffer ) { | |||
|
|
|||
| return parseV2f( dataView, offset ); | |||
|
|
|||
| } else if ( type == 'int' ) { | |||
There was a problem hiding this comment.
Can you please use the strict comparison operator (===) in EXRLoader? That would be great for code style 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of tiny fixes for the EXRLoader, notably adds better support for EXRs exported from Nuke.
@mrdoob @Mugen87