Handle normal/bump maps when material is back/double-sided #13916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @donmccurdy This code works in my tests, but I have not been able to test with your test cases. |
I'm seeing this behavior correctly for NormalTangentTest, NormalTangentMirrorTest, and DamagedHelmet glTF models. |
donmccurdy
approved these changes
Apr 22, 2018
mrdoob
reviewed
Apr 23, 2018
|
|
||
| float fDet = dot( vSigmaX, R1 ); | ||
|
|
||
| fDet *= ( float( gl_FrontFacing ) * 2.0 - 1.0 ); |
There was a problem hiding this comment.
Is this intentional? Should it just be...
float fDet = dot( vSigmaX, R1 ) * float( gl_FrontFacing );There was a problem hiding this comment.
What I have coded was intentional and works in my tests. It is equivalent to a sign flip if back-facing.
There was a problem hiding this comment.
Ah, I see. This code multiplies fDet by 1.0 or -1.0. Looks good!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both double-sided and back-sided materials, we want extrusions when viewed from the front side, to appear as indentations when viewed from the back side.
This PR should ensure that behavior for both normal maps and bump maps.