Skip to content

Conversation

WestLangley
Copy link
Collaborator

First draft. Had to keep it simple.

One clear limitation of "fat lines" is they render in screen-space. Consequently, a solid mesh rendered with a wireframe overlay -- a reasonable use case -- doesn't look very good... Well, it may be OK for "thin fat lines".

@Usnul
Copy link
Contributor

Usnul commented Jun 11, 2018

I like the example, but don't like the name, it feels like fat shaming.

@mrdoob mrdoob added this to the r94 milestone Jun 12, 2018
@pailhead
Copy link
Contributor

pailhead commented Jun 12, 2018

I'm experiencing this #14197, definitely in favor of calling this thick instead of fat. Much better to set thickness than fatness.

@WestLangley
Copy link
Collaborator Author

don't like the name, it feels like fat shaming.

Oh, give me a break.

Much better to set thickness than fatness.

The lines do not have to be thick. We set lineWidth.

@looeee
Copy link
Collaborator

looeee commented Jun 12, 2018

Also experiencing #14197.

I don't have a particular problem with the name, but perhaps "thick" is more accurate. Since the parameter is called "width", it makes more sense to be setting the "thickness" than the "fatness".

The lines do not have to be thick. We set lineWidth.

The lines don't have to be fat either.

@XanderLuciano
Copy link
Contributor

Also experiencing #14197 with thicc lines.

Windows 10, GTX 1070, Chrome 66, 69, and Firefox 66.

@WestLangley
Copy link
Collaborator Author

@XanderLuciano That should have been fixed in #14279.

@XanderLuciano
Copy link
Contributor

XanderLuciano commented Jun 13, 2018

You're everywhere West! Nice work as usual. Didn't realize that specific fix was a patch in the core library shader portion of the library (as opposed to an issue with THREE.LineMaterial itself).

@pailhead
Copy link
Contributor

Its not a fix in the core.

@mrdoob mrdoob merged commit b27152b into mrdoob:dev Jun 16, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2018

Thanks!

Repository owner deleted a comment from mrdoob Jun 16, 2018
@WestLangley WestLangley deleted the dev-fat_wirefame branch June 16, 2018 15:26
@callumprentice
Copy link
Contributor

Experimenting with this and adding a whole bunch of THREE.Line2(..)s to a base THREE.Object3D().

I calculate a bounding box adjusting the camera and fitting the resulting mesh to the screen using

var bbox = new THREE.Box3().setFromObject(obj3d);

works for other types of geometry but not Line2 - something extra I need to do here?

@WestLangley
Copy link
Collaborator Author

@callumprentice

LineSegmentsGeometry extends InstancedBufferGeometry; positions are updated on the GPU.

Box3.setFromObject() will not work correctly when applied to any object whose vertices are updated on the GPU.

LineSegmentsGeometry.computeBoundingBox() should work, though.

If you need further help, please direct your questions to the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants