Skip to content

Fix PLYExporter includeIndices LGTM warning #14772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Fix PLYExporter includeIndices LGTM warning #14772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/js/exporters/PLYExporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ THREE.PLYExporter.prototype = {
var includeNormals = false;
var includeColors = false;
var includeUVs = false;
var includeIndices = true;

// count the vertices, check which properties are used,
// and cache the BufferGeometry
Expand Down Expand Up @@ -123,10 +122,10 @@ THREE.PLYExporter.prototype = {

} );

var includeIndices = excludeAttributes.indexOf( 'index' ) === - 1;
includeNormals = includeNormals && excludeAttributes.indexOf( 'normal' ) === - 1;
includeColors = includeColors && excludeAttributes.indexOf( 'color' ) === - 1;
includeUVs = includeUVs && excludeAttributes.indexOf( 'uv' ) === - 1;
includeIndices = includeIndices && excludeAttributes.indexOf( 'index' ) === - 1;


if ( includeIndices && faceCount !== Math.floor( faceCount ) ) {
Expand Down