Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshPhysicalMaterial: Added sheen textures. #22687

Merged
merged 4 commits into from
Oct 28, 2021
Merged

MeshPhysicalMaterial: Added sheen textures. #22687

merged 4 commits into from
Oct 28, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 14, 2021

Related issue: -

Description

To make the sheen code more glTF conform, this PR adds sheenTintMap and sheenRoughnessMap which are the glTF pendants to sheenColorTexture and sheenRoughnessTexture.

@mrdoob
Copy link
Owner

mrdoob commented Oct 14, 2021

Before we go too far down this path...

I think it's not too late to rename "Tint" to "Color".
It'd follow material.color which has always acted as a "tint" too.

So the change would be:

attenuationTint > attenuationColor
sheenTint > sheenColor
sheenTintMap > sheenColorMap
specularTint > specularColor
speculatTintMap > specularColorMap

@WestLangley If you don't hate this naming too much I can do the change after merging this 😇

@mrdoob mrdoob added this to the r134 milestone Oct 14, 2021
@WestLangley
Copy link
Collaborator

@WestLangley If you don't hate this naming too much...

@mrdoob hehe. It's OK with me. :-)

@mrdoob
Copy link
Owner

mrdoob commented Oct 14, 2021

Sweet! I'll do the change tomorrow 😀

@mrdoob
Copy link
Owner

mrdoob commented Oct 28, 2021

Sweet! I'll do the change tomorrow 😀

Damn, the last two weeks have been intense...

@mrdoob mrdoob merged commit abeff12 into mrdoob:dev Oct 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 28, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Nov 2, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants