Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvexGeometry: Support clone(). #23177

Merged
merged 1 commit into from
Jan 8, 2022
Merged

ConvexGeometry: Support clone(). #23177

merged 1 commit into from
Jan 8, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 8, 2022

Fixed #23176.

Description

Ensures ConvexGeometry uses the same pattern of built-in geometry generators to support clone().

@Mugen87 Mugen87 added this to the r137 milestone Jan 8, 2022
@Mugen87 Mugen87 merged commit 0f19a3e into mrdoob:dev Jan 8, 2022
@rogerscg
Copy link

rogerscg commented Jan 8, 2022

Wow, thanks for the speedy response @Mugen87

@mrdoob
Copy link
Owner

mrdoob commented Jan 11, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Jan 19, 2022
Closed
20 tasks
@Glavin001 Glavin001 mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.

ConvexGeometry cloning does not work as the constructor requires a set of points
3 participants
@Mugen87 @rogerscg @mrdoob