GLTFExporter: Fixed buildMetalRoughTexture #24197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think cached canvas can be present, and used exporting multiple images. |
|
@repalash Feel free to submit a PR. Make sure it doesn't break anything 👍 |
|
Something like a flag passed to the |
|
I'm just not sure it's worth it... |
|
Yeah, less not try to make the code "too smart". Makes it only harder to maintain. |
|
Sorry I wasn't able to work on this! But I think this is the right fix for now 👍 |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24164
Description
The use of
cachedCanvasresulted in #23857 breakingbuildMetalRoughTexture().Seems like a classic case of premature optimization to me.