WebGPU: Compute Particles #26655
Merged
WebGPU: Compute Particles #26655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2023
Merged
|
Very nice! |
LeviPesin
reviewed
Sep 5, 2023
| @@ -39,7 +39,7 @@ class StackNode extends Node { | |||
|
|
|||
| if( boolNode, method ) { | |||
|
|
|||
| const methodNode = shader( method ); | |||
| const methodNode = new ShaderNode( method ); | |||
There was a problem hiding this comment.
shader was deprecated, I think that soon ShaderNode will be replaced by TSL function tslFn, but for this we need to create ShaderNodeCall, otherwise the function is called without builder and stack parameters for some cases.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following example shows how easy and powerful it is to create particles using
TSLandWebGPURenderer.https://raw.githack.com/mrdoob/three.js/dev/examples/webgpu_compute_particles.html