Skip to content

Basic and Lambert variations examples #7396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2015
Merged

Basic and Lambert variations examples #7396

merged 5 commits into from
Oct 21, 2015

Conversation

bhouston
Copy link
Contributor

I also fixed a bug with Physical where reflectivity wasn't defined in some cases.

@bhouston
Copy link
Contributor Author

The new examples:

http://ci.threejs.org/api/pullrequests/7396/examples/webgl_materials_lambert_variations.html
http://ci.threejs.org/api/pullrequests/7396/examples/webgl_materials_basic_variations.html

mrdoob
mrdoob reviewed Oct 21, 2015
View reviewed changes
src/renderers/shaders/ShaderChunk/envmap_pars_fragment.glsl Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't reflectivity only used when MeshPhysicalMaterial has an envMap?

@bhouston
Copy link
Contributor Author

I think you are right, I've undone that change.

mrdoob added a commit that referenced this pull request Oct 21, 2015
@mrdoob
Merge pull request #7396 from bhouston/material_variations_examples
9b0f5f4 
Basic and Lambert variations examples
@mrdoob mrdoob merged commit 9b0f5f4 into mrdoob:dev Oct 21, 2015
@mrdoob
Copy link
Owner

mrdoob commented Oct 21, 2015

Thanks!

@bhouston bhouston deleted the material_variations_examples branch March 14, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhouston @mrdoob