CatmullRomCurve3 supports .closed property

[zz85]

• Basic unit tests added for ClosedSplineCurve3 and CatmullRomCurve3 (inside test/unit/unittests_sources.html)
• CatmullRomCurve3 supports .closed property
• ClosedSplineCurve3 now has depreciation message
• ClosedSplineCurve3 uses CatmullRomCurve3 internally for transition plan

Relates to #7587

If we are ok on the change, I could help to update the documentation too

@WestLangley @mrdoob

[zz85]

btw @gero3 - nice stuff, I see ci.threejs also works on the tests :) http://ci.threejs.org/api/pullrequests/7686/test/unit/unittests_sources.html?filter=curve

just curious, where is ci hosted on? are you able to turn on gzip compression (would help speed up the loading ;)

[WestLangley]

Don't you need to create a .closed property, then?

How does .closed differ from .autoClose?

[zz85]

.closed if undefined would default to being false. .closed when set to true would mean that its a catmullrom path which is in a loop.

I believe .autoClose is intended for Path which is to support the canvas like 2d api . closePath().

Where else this .closed means that since the catmullrom path is circular, the weights of the first points would use the last points and the last points would be affected by the first points.

[mrdoob]

How about setting .close to false by default? That way we don't modify the hidden class.

[zz85]

hmm, I didn't think of that, now updated .closed to false. (would be useful if there's some v8 debugging tools which warns when additional hidden classes are created).

[zz85]

👌Updated documentation too.

[WestLangley]

THREE.ClosedSplineCurve3 has been deprecated. Please use THREE.CatmullRomCurve3

[zz85]

thanks @WestLangley

[WestLangley]

Your welcome, but I think you mean deprecated, not depreciated. (2 instances)

[zz85]

argh yes!!! fixed again..

[zz85]

bump

[mrdoob]

Shouldn't this go in Curve.js instead?

THREE.Curve = function () {
    this.closed = false;
};

[zz85]

Right now it feels to me that .closed is a property of CatmullRomCurve3 rather than Curve. If .closed is a property of Curve then all curves should support using this property which we currently don't...

[mrdoob]

I see. Yeah, that makes sense.

[mrdoob]

Thanks!