Skip to content

Conversation

@L-Lawlite
Copy link
Contributor

  • Fixed resource Locator to correct format.
  • Removed warnings by adding package-info file.
  • Fixed Some serilization related problems. Still more left

Left to do

  • Serilization
  • Porting items to use components. (Added comments in some places to as reminder)
  • Config for neoforge

@piotrenewicz
Copy link
Contributor

piotrenewicz commented Apr 11, 2025

I think your changes on playerWillDestroy were better.
I just ported it to playerDestroy because that's what my IDE recommended, didn't realize it has changed the return type.

@piotrenewicz
Copy link
Contributor

The merge at the end has pulled my version of playerDestroy into your PR, in blocks/energy_meter/EnergyMeterBlock.java

@L-Lawlite
Copy link
Contributor Author

The merge at the end has pulled my version of playerDestroy into your PR, in blocks/energy_meter/EnergyMeterBlock.java

Oops. @mrh0 please remove that after merging.

@piotrenewicz
Copy link
Contributor

You could still make a revert commit in your branch before the PR gets accepted

Copy link
Owner

@mrh0 mrh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thanks!

@mrh0 mrh0 merged commit 19bb92c into mrh0:1.21.1 Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants