Skip to content

Conversation

@tastytea
Copy link
Contributor

GNUInstallDirs are portable, many users are familiar with them and they make the
life of package maintainers easier.


Checklist

Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

  • CI passes
  • Description of proposed change
  • Documentation (README, code doc blocks, etc) is updated
  • Existing issue is referenced if there is one
  • Unit tests for the proposed change

CMake compatibilty

GNUInstallDirs is available in 3.10:
https://cmake.org/cmake/help/v3.10/module/GNUInstallDirs.html.

Reasoning

Linux distributions usually have profiles for CMake that set these directories
to the right locations. This change will make packaging easier.

Other

I have left the old variables intact for backwards compatibility.

GNUInstallDirs are portable, many users are familiar with them and they make the
life of package maintainers easier.
@mrtazz
Copy link
Owner

mrtazz commented Feb 12, 2020

thank you!

@mrtazz mrtazz merged commit 8c4c717 into mrtazz:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants