Add CURL and Threads as dependency in CMake config. #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use find_dependency() to depend on CURL and Threads so CMake users don't have to
do it themselves.
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.
CMake compatibilty
CMakeFindDependencyMacroandfind_dependency()are available in 3.10:https://cmake.org/cmake/help/v3.10/module/CMakeFindDependencyMacro.html.
FindCurlis available in 3.10:https://cmake.org/cmake/help/v3.10/module/FindCURL.html.
FindThreadsis available in 3.10:https://cmake.org/cmake/help/v3.10/module/FindThreads.html.
Reasoning
Since curl and threads are not optional, they should be required by
restclient-cppConfig.cmake, in my opinion. It makes the CMakeLists.txt ofusers a bit cleaner and shorter and has no downsides, as far as I'm aware.
Before:
After:
find_package(restclient-cpp 0.5 REQUIRED CONFIG)