Fix missing cstdint include #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code did not compile under GCC-13 because libstdcpp headers have changed such that cstdint is not included implicitly. Add cstdint include when `uint64_t` types are used. Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
facebook-github-bot
pushed a commit
to facebook/openbmc
that referenced
this pull request
Jun 17, 2023
Summary:
The current code doesn't compile under GCC-13. I've submitted a fix
upstream and applied it here:
mrtazz/restclient-cpp#189
I've also done some minor clean up of the recipe.
Test Plan: Build is successful.
Reviewed By: jagpalgill
Differential Revision: D46811268
fbshipit-source-id: 810e134bf8dc20e09cfc7e678f1523f5b32e1d65
Owner
|
thanks for taking the time to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code did not compile under GCC-13 because libstdcpp
headers have changed such that cstdint is not included implicitly.
Add cstdint include when
uint64_ttypes are used.Signed-off-by: Patrick Williams patrick@stwcx.xyz