Added support for progress reporting when downloading/uploading #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Can you please make sure this change has unit tests, works on CI, and has an example usage documented in the README? |
* Added unit test for progress callback. * Updated `README.md` with documentation for the new progress callback additions.
Contributor
Author
|
So this is failing as the code isn't compiled with C11 support. Is there any good reason we can't baseline to this now? Or as a minimum have that turned on for the tests? |
Owner
|
C11 support is fine to add I think. We have other places now that kinda need it anyways. |
Contributor
Author
Looks like C11 support has been added for the test suite now :) I've merged in latest master & resolved the conflict. Let me know your thoughts 👍 |
Owner
|
perfect! thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.