Merge pull request #96 from msgpack/typescript_eslint/2.14.0

Upgrade typescript-eslint to 2.14.0

Author: gfx

.eslintrc.js

@@ -35,34 +35,37 @@ module.exports = {
     "import/no-cycle": "error",
     "import/no-default-export": "error",
 
-    "@typescript-eslint/no-unused-vars": "warn",
+    "@typescript-eslint/await-thenable": "warn",
     "@typescript-eslint/array-type": ["warn", { default: "generic" }],
     "@typescript-eslint/camelcase": "warn",
     "@typescript-eslint/class-name-casing": "warn", // to allow the initial underscore
+    "@typescript-eslint/restrict-plus-operands": ["warn", { "checkCompoundAssignments": true }],
     "@typescript-eslint/no-non-null-assertion": "warn", // NOTE: pay attention to it because it may cause unexpected behavior
+    "@typescript-eslint/no-throw-literal": "warn",
+    "@typescript-eslint/no-extra-semi": "warn",
+    "@typescript-eslint/no-extra-non-null-assertion": "warn",
+    "@typescript-eslint/no-unused-vars": "warn",
+    "@typescript-eslint/no-use-before-define": "warn",
+    "@typescript-eslint/no-for-in-array": "warn",
+    "@typescript-eslint/no-unnecessary-condition": ["warn", { "allowConstantLoopConditions": true }],
     "@typescript-eslint/prefer-for-of": "warn",
     "@typescript-eslint/prefer-includes": "warn",
     "@typescript-eslint/prefer-string-starts-ends-with": "warn",
     "@typescript-eslint/prefer-readonly": "warn",
     "@typescript-eslint/prefer-regexp-exec": "warn",
-    "@typescript-eslint/no-use-before-define": "warn",
-    "@typescript-eslint/await-thenable": "warn",
-    "@typescript-eslint/no-for-in-array": "warn",
     "@typescript-eslint/prefer-nullish-coalescing": "warn",
     "@typescript-eslint/prefer-optional-chain": "warn",
-    "@typescript-eslint/no-extra-non-null-assertion": "warn",
-    "@typescript-eslint/restrict-plus-operands": ["warn", { "checkCompoundAssignments": true } ],
 
     "@typescript-eslint/indent": "off",
-    "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/explicit-member-accessibility": "off",
+    "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-object-literal-type-assertion": "off",
     "@typescript-eslint/no-empty-interface": "off",
+    "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/no-parameter-properties": "off",
     "@typescript-eslint/no-var-requires": "off", // enforces `import x = require("x")`, which is TypeScript-specific
     "@typescript-eslint/prefer-interface": "off",
-    "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/ban-ts-ignore": "off",
 
     "prettier/prettier": "warn",

.vscode/settings.json

@@ -1,10 +1,7 @@
 {
-  "eslint.autoFixOnSave": true,
-  "eslint.validate": [
-    "javascript",
-    { "language": "typescript", "autoFix": true },
-    { "language": "typescriptreact", "autoFix": true }
-  ],
   "typescript.tsdk": "node_modules/typescript/lib",
-  "files.eol": "\n"
+  "files.eol": "\n",
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  }
 }

package-lock.json

@@ -387,7 +387,9 @@ export class Decoder {
           state.key = object;
           state.type = State.MAP_VALUE;
           continue DECODE;
-        } else if (state.type === State.MAP_VALUE) {
+        } else {
+          // it must be `state.type === State.MAP_VALUE` here
+
           // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
           state.map[state.key!] = object;
           state.readCount++;