Skip to content

Conversation

@gfx
Copy link
Member

@gfx gfx commented May 4, 2021

Decoder's state breaks if it tries to decode broken inputs, and there's no way to recover. This PR resets the state in initialization.

This will mitigate #160.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #173 (5295681) into main (afd1885) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          15       15           
  Lines         960      961    +1     
  Branches      207      207           
=======================================
+ Hits          942      943    +1     
  Misses         18       18           
Impacted Files Coverage Δ
src/Decoder.ts 99.17% <100.00%> (+<0.01%) ⬆️
src/Encoder.ts 97.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd1885...5295681. Read the comment docs.

@gfx gfx merged commit b9739e3 into main May 4, 2021
@gfx gfx deleted the decoder-recover-after-errors branch May 4, 2021 02:16
@gfx gfx mentioned this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants