Skip to content

🎨 code lint #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

🎨 code lint #66

merged 1 commit into from
Nov 30, 2023

Conversation

@lwnmengjing
Copy link
Member

@lwnmengjing lwnmengjing commented Nov 30, 2023 •
edited
Loading

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (main)
  • no unintentional fmt.Print left behind after debugging
  • did I name variables, methods and classes according to the naming rules? (https://go.dev/doc/effective_go#names)
  • caught exceptions or throw them to the upper level for processing, not ignored (https://go.dev/doc/effective_go#errors)
  • did I explain all possible solutions and why I chose the one I did?
  • added any comments to make new functions clearer
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors
  • instructions for how reviewers can test the code locally
  • screenshot of the feature/bug fix (if applicable)

@lwnmengjing lwnmengjing merged commit d5e71ed into mss-boot-io:main Nov 30, 2023
@lwnmengjing lwnmengjing deleted the fix/lint branch November 30, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lwnmengjing