thread 'tokio-runtime-worker' panicked at 'couldn't send data: hyper::Error(ChannelClosed)'

[mhansen]

Hi there,

I'm trying samply, and I'm investigating another error. As part of this, I loaded the profile JSON file in my browser of a big profile (a command that took about a minute to run):

http://127.0.0.1:3000/0bsfmf5h5zphwf000la4nyaqkp18pjpjz9wpxbw/profile.json

And closed the browser tab halfway through the transfer.

The samply process panicked:

All tasks terminated.
Local server listening at http://127.0.0.1:3000
Press Ctrl+C to stop.
thread 'tokio-runtime-worker' panicked at 'couldn't send data: hyper::Error(ChannelClosed)', /Users/mark/.cargo/registry/src/github.com-1ecc6299db9ec823/samply-0.10.1/src/server.rs:408:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behaviour: servers shouldn't panic and quit when a client closes the connection mid-transfer, should keep on running.

[mhansen]

Code was here:

                    sender                                                                                 
                        .send_data(Bytes::copy_from_slice(&contents[..data_len]))                          
                        .await                                                                             
                        .expect("couldn't send data");                                                     

Looks like this was fixed in 8b92631 but needs a release that includes that

[mhansen]

I'll use the HEAD version for now.

[mstange]

I just released 0.11.0 which includes the fix.

[mhansen]

Thank you!

…

On Sat, 7 Jan 2023 at 06:09, Markus Stange ***@***.***> wrote: Closed #11 <#11> as completed. — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZYOL333HJMRMXD3Y7WWLWRBUXBANCNFSM6AAAAAATPH6TZY> . You are receiving this because you authored the thread.Message ID: ***@***.***>