feat: add geotiff support valhalla isochrones #150
Conversation
|
|
||
| return Isochrones(isochrones, response) | ||
|
|
||
| def raster( # noqa: C901 |
There was a problem hiding this comment.
it's the same parameters as for isochrones. I'm sure this can be done better to make sure both use the same parameters
There was a problem hiding this comment.
/raster is what was already done for opentripplanner. in the spirit of "one api to rule them all" I guess it's better than making it a parameter for /isochrone
|
this depends on valhalla/valhalla#5665. routingpy's logic is based on the response's Content-Type header, which is currently wrong in valhalla. that also means I've gone full circle.. change smth in valhalla -> want to change qgis plugin -> need to change routingpy -> need to change valhalla, that's hilarious and awful haha |
|
valhalla/valhalla#5665 is merged, so this PR is ready too. |
nilsnolde
force-pushed
the
nn-valhalla-geotiff
branch
from
2bd4168 to
e90838d
Compare
|
fwiw, I also implemented this in the plugin already in nilsnolde/valhalla-qgis-plugin@a23e191. works nicely |
1 participant
fixes #149
basically a copy of the existing OTP implementation.