mturley
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
925 contributions in the last year
Activity overview
Contribution activity
October 2020
Created a pull request in konveyor/virt-ui that received 13 comments
Restructure mapping steps of wizard, use form state for mapping builder items, fix wizard corner cases
Resolves #103
Another big one... I'm pretty sure this finalizes all the wizard logic* except for actually creating the CRs.
*welp, looks like we al…
+1,050
−550
•
13
comments
- Add useCreatePlanMutation and usePlansQuery hooks, refactor plan object types to match API, clean up plan / plan details pages
- Add useCreateMappingMutation and useMappingsQuery hooks, refactor mapping object types to match API, clean up mapping pages
- Add target namespace selection to General step of plan wizard
- Clean up types and async error handling, add mockable mutation helper, display error message on AddProviderModal
- Use virtMeta.json with a capital M everywhere
- Upgrade lib-ui to bring in useFormState, delete local useFormState, replace imports
- test
- Plan wizard: Select VMs step: traverse tree selections to generate VM selection table contents
- Fix handling of CORS errors in authorizedFetch
- Add useFormState to plan wizard, add tree conversion and selection logic, fix some layout, TS and a11y stuff
- fix(useformstate): don't memoize schema (so it can be conditional), allow non-required text fields
- fix(build): import axios conditionally to make it a truly optional dependency
- feat(useformstate): add useFormState hook, ValidatedTextInput component and initial docs
- fix(package.json): treat axios properly as an external peer dependency
- feat(useselectionstate): add selectMultiple function for atomically updating multiple items at once
- feat(useselectionstate): add support for externally lifted state
- Use TableEmptyState when filtering returns no results
- Make most relevant status to surface
- Handle token expiry
- Adds filter to VMMigrationDetails
- Adds filter to all SelectVMs columns
- Use create provider hook to create provider & relevant secret
- Add FilterToolbar to migration plan table
- useFilterState generic
- Cloud MA link
- useFormState for SelectNetworkModal and AddEditMappingModal
- Add Dockerfile for konveyor/virt-ui
- Remove Hooks
- Add Icon and color to each step
- Create text for new mapping
- Select Host mapping network more details
- Pipeline summary
- Self signed cert error handling & reusable http service hook
- MappingBuilder enable/disabled add and remove buttons
- Disable Kebab unless conditions are met
- Plans details table
- Move PlanWizard to its own page
- Toggle menu after selection only in mobileView
Created an issue in konveyor/virt-ui that received 2 comments
Add a field for selecting the target namespace for a plan
This came up in an email thread (subject: "How do we set target project?"), and it looks like we'll need to add a field to the General step of the …
2
comments
- When oauth flow encounters an error it causes a redirect loop
- [Post-beta?] Look into proxying inventory and host cluster APIs through Express to avoid SSL/CORS errors
- Add query/useMutation hook for creating plans
- [Post-beta] Add time range filter category type, use instead of search filter for filtering on timestamps
- Render empty state instead of tables when filters result in no rows appearing in the table
- Handle CRUD for Host CR (getting and setting IP address for a vmware host)
- Update instructional text on new mappings steps of wizard
- Post-beta enhancements
- Add FilterToolbar to Select VMs step of wizard
- Make titles consistently sentence case / title case?
- Enforce that user cannot create a plan or mapping with the name of an existing plan/mapping
- Add links to product documentation when available
- Follow up when VM `concerns` array `severity` types are finalized
- Incorporate ResourcesEmptyIcon in the pipeline summary component once it is available in PF
- Super-low-priority: Mappings pages should be unified into one page with tabs, consistent with providers
- Button text for creating mappings/plans should always say "Create" and not "Add [plan|mapping]"
- Set link href for cloud.redhat.com links
- Wire up "Download data" button for VMware providers to MA payload API
- Remove Hooks views
- Add support for editing existing migration plans
- Restructure mapping steps of wizard based on new mockups
- Disable edit and remove actions on plans that are not "fresh" (any plan that is migrating, completed or failed)
4
contributions
in private repositories
Oct 12