fix: handle multi-type arrays in JSON schema to prevent panic #6495
Conversation
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic that occurred when processing JSON schemas with nullable parameters using multi-type arrays (e.g., "type": ["string", "null"]). The code previously assumed type values were always strings and would crash when encountering arrays. The fix adds type checking to handle both single-type strings and multi-type arrays, generating appropriate grammar rules for union types.
Key changes:
- Added type safety when parsing schema type fields to handle both strings and arrays
- Implemented grammar generation for multi-type unions by creating OR rules
- Added comprehensive test coverage for multi-type array scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/functions/grammars/json_schema.go | Added type checking logic to handle both single-type strings and multi-type arrays, with grammar generation for union types |
| pkg/functions/grammars/json_schema_test.go | Added test cases covering multi-type array definitions and complex nested schemas with nullable fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if ruleName == "root" { | ||
| schemaType = "root" | ||
| // Handle primitive types, including multi-type arrays like ["string", "null"] | ||
| if len(schemaTypes) > 1 { |
There was a problem hiding this comment.
a small style nit: would make sense to contract this and make it an else if ...
2 participants
Description
This PR fixes #5572
When you send a function definition to LocalAI with nullable parameters (using
"type": ["string", "null"]like OpenAI does in strict mode), the server would immediately crash. This happened because the code assumed type was always a single string and tried to force-convert it, which panics when it's actually an array.Notes for Reviewers
Signed commits