Skip to content

Conversation

@mkhludnev
Copy link
Contributor

Description

This PR fixes #7212

Notes for Reviewers

  • assert rerank results - sorting and cropping.
  • 422 if top_n <1
  • let to omit top_n

Signed commits

  • [v] Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Nov 16, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit d9f737e
🔍 Latest deploy log https://app.netlify.com/projects/localai/deploys/6919efa9c544ee0008ce4402
😎 Deploy Preview https://deploy-preview-7284--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mkhludnev mkhludnev changed the title reranker tests and top_n check fix #7212 fix(reranker): tests and top_n check fix #7212 Nov 16, 2025
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@mudler mudler enabled auto-merge (squash) November 16, 2025 16:08
@mudler mudler disabled auto-merge November 16, 2025 16:53
@mudler mudler merged commit c313b2c into mudler:master Nov 16, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check /reranker top_n at the REST level

2 participants