-
Notifications
You must be signed in to change notification settings - Fork 0
feat(chat-receipe) Add receipe #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| console.log('Gemini response completed successfully.'); | ||
| } | ||
| }); | ||
| // this.subscription = this.genAiService.askGemini(text).subscribe({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented this out for the time being, as we might get rid of that. The service is the most important part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i think is, Rather than commenting whole code just remove the ngOnInit call to that function statement.
| { | ||
| path: 'chat', | ||
| loadComponent: () => | ||
| import('../pages/chat/chat.component').then((c) => c.ChatComponent), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this extra ,
| production: false, | ||
| googleAiKey: "" | ||
| } | ||
| production: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting is applied everywhere. please be commit the changes only related to you exactly. i saw many places, spaces updates.
| @@ -0,0 +1,75 @@ | |||
| .chat-container { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i think is we shouldn't add more time writing CSS here, let's just consume Bootstrap. more simple and fast.
| }) | ||
| export class ChatComponent { | ||
| messages: { text: string; isUser: boolean }[] = []; | ||
| userInput = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type string missing here --- "Good to have"
| export class ChatComponent { | ||
| messages: { text: string; isUser: boolean }[] = []; | ||
| userInput = ''; | ||
| isLoading = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type boolean missing here --- "Good to have"
|
|
||
| @Injectable({ | ||
| providedIn: 'root' | ||
| providedIn: 'root', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting issue, added extra comma, however it's not required.
| /** | ||
| * Communicate with Gemini - Google Ai using text prompt | ||
| */ | ||
| askGemini(prompt: string): Observable<string> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix linting issues
No description provided.