Skip to content

Conversation

@sonukapoor
Copy link
Collaborator

No description provided.

console.log('Gemini response completed successfully.');
}
});
// this.subscription = this.genAiService.askGemini(text).subscribe({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented this out for the time being, as we might get rid of that. The service is the most important part.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i think is, Rather than commenting whole code just remove the ngOnInit call to that function statement.

{
path: 'chat',
loadComponent: () =>
import('../pages/chat/chat.component').then((c) => c.ChatComponent),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this extra ,

production: false,
googleAiKey: ""
}
production: false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting is applied everywhere. please be commit the changes only related to you exactly. i saw many places, spaces updates.

@@ -0,0 +1,75 @@
.chat-container {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i think is we shouldn't add more time writing CSS here, let's just consume Bootstrap. more simple and fast.

})
export class ChatComponent {
messages: { text: string; isUser: boolean }[] = [];
userInput = '';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type string missing here --- "Good to have"

export class ChatComponent {
messages: { text: string; isUser: boolean }[] = [];
userInput = '';
isLoading = false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type boolean missing here --- "Good to have"


@Injectable({
providedIn: 'root'
providedIn: 'root',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting issue, added extra comma, however it's not required.

/**
* Communicate with Gemini - Google Ai using text prompt
*/
askGemini(prompt: string): Observable<string> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix linting issues

@muhammadawaisshaikh muhammadawaisshaikh added enhancement New feature or request google-ai ai using gemini angular Angular changes are included labels Oct 29, 2024
@muhammadawaisshaikh muhammadawaisshaikh merged commit 589eb86 into main Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular Angular changes are included enhancement New feature or request google-ai ai using gemini

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants