[material-ui-icons] reduce code duplication?

[cherniavskii]

I've noticed, that every file in src directory implements props forwarding, sets muiName, checks global.__MUI_SvgIcon__ and so on, which leads to code duplication in bundle.

Generally, the unique content of every icon is it's path. All other stuff is common for every icon.

So it should be possible to create single HOC, which does all common stuff. Then use it in every file, providing path and export the result.

What do you think?

[oliviertassinari]

@cherniavskii Some of your concern will be solved by #9469.

An example of icon we have today: https://unpkg.com/material-ui-icons@1.0.0-beta.36/AcUnit.js.
I agree, there is room for improvement! It won't make a huge difference given that people use at most 10 icons per page but still 👍 .

[cherniavskii]

Ok, I'll submit a PR then :)

[mbrookes]

HOCs have an overhead too, so it's a trade-off. We debated it before and decided against it.

[oliviertassinari]

@mbrookes It's not about using an HOC. It's about using a component factory.

[cherniavskii]

@mbrookes from where I stand, HOC is a perfect solution for this particular use case.
Can you tell more about HOC overhead?

[cherniavskii]

BTW, looks like I wasn't talking about HOC in classical term, it's indeed more like a factory.
Anyway, I'll submit a PR soon, please take a look. No pressure ;)

[cherniavskii]

Ok, it's WIP, but main concept is already there