Fix: Fixed command run on Windows

Author: jarrodek

lib/dependencies.js

@@ -6,7 +6,7 @@
  * @author Pawel Psztyc
  */
 const {DependenciesOptions} = require('./dependencies-options');
-const {exec} = require('child_process');
+const {spawn} = require('child_process');
 const fs = require('fs-extra');
 const path = require('path');
 const platform = process.platform;
@@ -112,18 +112,31 @@ class DependendenciesManager {
    * Prepares bower command options depending on environment and options.
    *
    * @param {String} command to execute, what is after `$ bower`
-   * @return {String} Full comand to execute.
+   * @return {object} Object containing the command and arguments
+   * - cmd {String} Command to call
+   * - args {Array<String>} List of arguments to send to the child process.
    */
-  _prepareBowerCommand(command) {
-    let cmd = this.commandRoot;
+  _prepareBowerCommand(...command) {
+    var args = [];
     if (!this.opts.verbose) {
-      cmd += ' --quiet';
+      args.push('--quiet');
     }
     if (this.runningRoot) {
-      cmd += ' --allow-root';
+      args.push('--allow-root');
     }
-    cmd += ' ' + command;
-    return cmd;
+    if (command && command.length) {
+      command.forEach(item => {
+        if (item instanceof Array) {
+          args = args.concat(item);
+        } else {
+          args.push(item);
+        }
+      });
+    }
+    return {
+      cmd: this.commandRoot,
+      args: args
+    };
   }
   /**
    * Processes dependencies installation.
@@ -148,7 +161,7 @@ class DependendenciesManager {
     return promise.then(() => {
       this.logger.info('Installing bower dependencies...');
       let cmd = this._prepareBowerCommand('install');
-      return this.exec(cmd);
+      return this.spawn(cmd.cmd, cmd.args);
     })
     .then(() => {
       this.logger.info('Dependencies installed.');
@@ -163,14 +176,17 @@ class DependendenciesManager {
    * installed.
    */
   _setBowerCommandRoot() {
-    const localCommand = path.join('.', 'node_modules', '.bin', 'bower');
+    var localCommand = path.join('.', 'node_modules', '.bin', 'bower');
+    if (isWin) {
+      localCommand += '.cmd';
+    }
     return fs.pathExists(localCommand)
     .then(exists => {
       if (!exists) {
         return this._ensureNpmPackage()
         .then(() => {
           this.logger.info('installing bower in ' + process.cwd());
-          return this.exec('npm install bower');
+          return this.spawn('npm', ['install', 'bower', '--no-save']);
         });
       }
     })
@@ -224,43 +240,42 @@ class DependendenciesManager {
     if (deps.length) {
       this.logger.info('Installing additional bower dependencies...');
       this.logger.info('Installing: ', deps);
-      let cmd = this._prepareBowerCommand('install ' + deps.join(' '));
-      return this.exec(cmd);
+      let cmd = this._prepareBowerCommand('install', deps);
+      return this.spawn(cmd.cmd, cmd.args);
     }
     return Promise.resolve();
   }
   /**
-   * Executea shell command
-   *
+   * Spawns process and execute task with output printed to the logger.
    * @param {String} cmd Command to execute
-   * @param {?String} dir A directoy where to execute the command.
-   * @return {Promise} Promise resolves itself if the command was executed
-   * successfully and rejects it there was an error.
+   * @param {Array<String>} args Arguments to pass to the command
+   * @return {Promise<String>} A promise resolved to an output of command execution.
    */
-  exec(cmd, dir) {
-    dir = dir || undefined;
+  spawn(cmd, args) {
+    args = args || [];
+    let log = `Executing command: ${cmd} with arguments: ${args.join(' ')} in ${process.cwd()}`;
+    this.logger.info(log);
     return new Promise((resolve, reject) => {
-      var opts = {};
-      if (dir) {
-        opts.cwd = dir;
-      }
-
-      let log = `Executing command: ${cmd}`;
-      if (dir) {
-        log += ` in dir: ${dir}`;
-      }
-      this.logger.info(log);
-      exec(cmd, opts, (err, stdout, stderr) => {
-        if (err) {
-          let currentDir = opts.cwd || process.cwd();
-          let message = '  Unable to execute previous command with error: ';
-          message += err.message.trim() + '.\n  Was in dir: ' + currentDir + '. stdout: ';
-          message += stdout + '. stderr: ' + stderr;
-          this.logger.error(message);
-          reject(new Error(err.message.trim()));
-          return;
+      const proc = spawn(cmd, args, {
+        shell: true
+      });
+      var result = '';
+      proc.stdout.on('data', (data) => {
+        let _res = data.toString('utf8');
+        result += _res;
+        this.logger.info(_res);
+      });
+      proc.stderr.on('data', (data) => {
+        let _res = data.toString('utf8');
+        result += _res;
+        this.logger.error(_res);
+      });
+      proc.on('close', (code) => {
+        if (code !== 0) {
+          reject('Command ' + cmd + ' failde with code ' + code);
+        } else {
+          resolve(result);
         }
-        resolve(stdout);
       });
     });
   }
@@ -272,7 +287,7 @@ class DependendenciesManager {
     if (isWin) {
       return Promise.resolve(false);
     }
-    return this.exec('id -u')
+    return this.spawn('id', ['-u'])
     .then((response) => {
       if (!response) {
         return false;