-
Notifications
You must be signed in to change notification settings - Fork 18
fix(client): pass correct client reference to root resources #50
Conversation
| } | ||
|
|
||
| return `${methodName}`; | ||
| }).join('.') + `.${camelCase(method.method)}([${type}, [options]])`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make this change because TSLint failed due to this string concatenation, it expects template literals.
| } | ||
| }; | ||
|
|
||
| return JSON.stringify(json, null, 2) + '\n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make this change because TSLint failed due to this string concatenation, it expects template literals.
|
|
||
| if (scheme.type === 'OAuth 2.0') { | ||
| this.buffer.return(); | ||
| this.buffer.line('// eslint-disable-next-line'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make this change because TSLint failed due to it expects two indentation spaces
| @@ -1,3 +1,5 @@ | |||
| dist: trusty | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis CI was failing, after researching a bit I found that dist: trusty is needed if xvfb is used directly.
Doc: https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-xvfb-directly
There is a minor issue that's causing an error executing root resources defined with path params.
Considering this path
/{user}, the resulted client is:Despite
usermethod is defined withinClientclass, theUserclass is instantiated withthis.client. Such property isn't defined insideClientand in fact, based on the logic, it expects a instance ofClientso just providingthisfixes the issue.After applying the fix, that portion of code looks like this: