Conversation
2 tasks
vmx
reviewed
Dec 5, 2022
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
LGTM. In cases where I depend on another PR, I usually add a [patch] section to the Cargo.toml, so that CI can pass.
Member
|
rust-multihash v0.18 was released, this should get CI green. |
Member
|
@dignifiedquire when you update the PR, could you please also add the breaking change information to the commit message? |
BREAKING CHANGE: add new method `Cid::encoded_len` and return `Result<usize>` now from `Cid::write_bytese`.
dignifiedquire
force-pushed
the
feat-encoded-len
branch
from
f206c96 to
7cad3f5
Compare
Member
Author
|
done |
Member
Author
|
The matching multihash PR has been released for a while now, can we move this forward? |
Member
|
Sorry for dropping the ball here, I'll work on it tomorrow. |
vmx
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on multiformats/rust-multihash#252