varint_read_u64 panics on unwrap in no_std environment#145
Merged
vmx merged 2 commits intomultiformats:masterfrom Oct 17, 2023
Merged
varint_read_u64 panics on unwrap in no_std environment#145vmx merged 2 commits intomultiformats:masterfrom
varint_read_u64 panics on unwrap in no_std environment#145vmx merged 2 commits intomultiformats:masterfrom
Conversation
…Error in the no_std environment.
6 tasks
mattheworris
added a commit
to frequency-chain/frequency
that referenced
this pull request
Oct 17, 2023
…vironment (#1719) # Goal The goal of this PR is to eliminate a panic discovered in fuzz testing. Closes #1712 # Discussion A PR was created in `multiformats/rust-cid` and merged to refactor `unwrap()` to return a Result in a `no_std` environment. See PR here: [multiformats/rust-cid/pull/145](multiformats/rust-cid#145) `Cargo.toml` was updated to be pinned to the PR commit with the fix in `rust-cid` # Checklist - [ ] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [x] Tests added - [ ] Benchmarks added - [ ] Weights updated --------- Co-authored-by: Matthew Orris <--help>
rustadot
pushed a commit
to rustadot/recurrency
that referenced
this pull request
Sep 5, 2024
…vironment (#1719) # Goal The goal of this PR is to eliminate a panic discovered in fuzz testing. Closes #1712 # Discussion A PR was created in `multiformats/rust-cid` and merged to refactor `unwrap()` to return a Result in a `no_std` environment. See PR here: [multiformats/rust-cid/pull/145](multiformats/rust-cid#145) `Cargo.toml` was updated to be pinned to the PR commit with the fix in `rust-cid` # Checklist - [ ] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [x] Tests added - [ ] Benchmarks added - [ ] Weights updated --------- Co-authored-by: Matthew Orris <--help>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to refactor
unwrap()to return theu64value or anError:VarIntDecodeErrorin theno_stdenvironment.This error was discovered in fuzz testing.
Tests were refactored to include a new
no_std_testsmodule, in order to test the fix.cargo test --no-default-featureswill execute theno_stdtest.