1.6: Fix warnings in crash handler

Author: Dutchman101

Client/core/CCrashDumpWriter.cpp

@@ -119,7 +119,7 @@ namespace
         static std::atomic_flag configured = ATOMIC_FLAG_INIT;
         if (!configured.test_and_set(std::memory_order_acq_rel))
         {
-            SymSetOptions(SYMOPT_LOAD_LINES | SYMOPT_UNDNAME | SYMOPT_FAIL_CRITICAL_ERRORS);
+            [[maybe_unused]] const auto previousOptions = SymSetOptions(SYMOPT_LOAD_LINES | SYMOPT_UNDNAME | SYMOPT_FAIL_CRITICAL_ERRORS);
         }
     }
 }            // namespace

Client/core/CExceptionInformation_Impl.cpp

@@ -200,7 +200,7 @@ class SymbolHandlerGuard
     if (!symbolGuard.IsInitialized())
         return std::nullopt;
 
-    SymSetOptions(SYMOPT_LOAD_LINES | SYMOPT_UNDNAME | SYMOPT_FAIL_CRITICAL_ERRORS);
+    [[maybe_unused]] const auto previousOptions = SymSetOptions(SYMOPT_LOAD_LINES | SYMOPT_UNDNAME | SYMOPT_FAIL_CRITICAL_ERRORS);
     alignas(SYMBOL_INFO) std::uint8_t symbolBuffer[sizeof(SYMBOL_INFO) + MAX_SYMBOL_NAME];
     memset(symbolBuffer, 0, sizeof(symbolBuffer));
     PSYMBOL_INFO pSymbol = reinterpret_cast<PSYMBOL_INFO>(symbolBuffer);

Client/core/CrashHandler.cpp

@@ -1154,8 +1154,8 @@ static void InstallAbortHandlers()
 
     bool disableSehDetourBool{false};
     bool forceSehDetourBool{false};
-    TryReadEnvBool("MTA_DISABLE_SEH_DETOUR", disableSehDetourBool);
-    TryReadEnvBool("MTA_FORCE_SEH_DETOUR", forceSehDetourBool);
+    [[maybe_unused]] const auto readDisableResult = TryReadEnvBool("MTA_DISABLE_SEH_DETOUR", disableSehDetourBool);
+    [[maybe_unused]] const auto readForceResult = TryReadEnvBool("MTA_FORCE_SEH_DETOUR", forceSehDetourBool);
 
     pConfig->disableSehDetour = disableSehDetourBool ? TRUE : FALSE;
     pConfig->forceSehDetour = forceSehDetourBool ? TRUE : FALSE;
@@ -1352,7 +1352,7 @@ static bool SafeSymGetLineFromAddr64(HANDLE hProcess, DWORD64 address, DWORD* pD
             {
                 initialized = true;
                 constexpr auto symOptions = SYMOPT_LOAD_LINES | SYMOPT_UNDNAME | SYMOPT_FAIL_CRITICAL_ERRORS;
-                SymSetOptions(symOptions);
+                [[maybe_unused]] const auto previousOptions = SymSetOptions(symOptions);
             }
         }