Refactor all post 1.5.7 funcs to use the new parser

[Pirulax]

I've talked with Qais, and he said it would be a big help to refactor all these new functions.

Also, the not done list:

• dxDrawPrimitive3D / dxDrawMaterialPrimitive3D - hard to read table structure. Its pretty specific, so i wont bother trying it with the new parser, will just add a big overhead.
• engineGetModelTextures - performance issue(returning std::unordred_map, with possibly a lot of strings: a lot of HEAP allocs, which would kill the performance. I suggest to implement std::vector<std::pair<const char*, Type*>>, or with string_view.
• SetColShapeSize - argument types depends on colshape type - impossible to do with the new parser(well, not impossible, but im not sure what would be the best way, ill leave it up to you)
• GetColPolygonPoints - modifying it would kill the performance because of std::vector heap allocation on return
• Add possibility of modifying dynamic objects behavior (#784)

Also, maybe its not the best place to discuss: I think adding the ability to return std::optional to the new parser would be dope. Theres a function in the col shape file, where I've left a TODO comment, because its ugly and we need a refactor.

[Pirulax]

I know there are a few messed up commits. Im sorry.

[Pirulax]

Seems like we either move
{"resetBlurLevel", CLuaDefs::ArgumentParser<CLuaFunctionDefs::ResetBlurLevel>}, to LuaDefs.World(Somehow, because CLuaManager loads all the defs from where) or we make CLuaDefs::ArgumentParser functions public or we do a private CLuaDefs to CLuaManager which would be dumb.

[Pirulax]

I also refactored the non OOP functions in ColShapeDefs to return numbers instead of vector(s)

[Pirulax]

There you go.
The build doesnt compile.
I need someone who could answer my previous question,

Seems like we either move
{"resetBlurLevel", CLuaDefs::ArgumentParserCLuaFunctionDefs::ResetBlurLevel}, to LuaDefs.World(Somehow, because CLuaManager loads all the defs from where) or we make CLuaDefs::ArgumentParser functions public or we do a private CLuaDefs to CLuaManager which would be dumb.

also, DxDrawWiredSphere has const SColorARGB color, how should we deal with that?

[qaisjp]

Annotated each suggested change with the name of the commit it should be melded into, so try and batch matching names if you accept the changes.

[Pirulax]

#1454 (comment)
@qaisjp
I cant comment on the issue, but no, its I've deleted the old function, and added the new, one liner(CStaticFDs was always returning true, so there was no need for that check)

[Pirulax]

Its still not compiling because we need to resolve the dxDrawWiredSphere argument SColorARGB. What should we do with that? Should I revert that commit? Or we implement SColorARGB?

@sbx320 I think I need your opinion here as well. I've asked about it before, but we didnt resolve it.

[qaisjp]

Implement SColor in a separate PR the same way the old parser works.

[Pirulax]

Alright, alright, there we go.
I did it this time.

[qaisjp]

Also, I didn't mention it earlier when I worked with you on the rebase since I didn't want to spend too much time with you watching rewords, but you need to reword every commit to be more clear.

"Refactor X" is not clear enough - someone must be able to read the commit message and know exactly what change was made.

It should be "Refactor X to use new Lua arg parser", and if there are other changes, include those in the commit descriptions.

[Pirulax]

Okay, no problem.
Ill do it tomorrow.

[Pirulax]

3261f1f, 6ed8668, 629e84e are messed up. I'm not quite sure how to fix it. I've googled it up, but the instructions on StackOverflow aren't totally clear to me, so if you could please explain it to me how could I change the contents of those commits, so they aren't totally messed up?

What I have in mind is to just cherry pick those 3 commits into a separate branch, there you can then separately commit each change (there a feature in VSC where you can select the lines, and make a commit out of the selected lines), and then just merge that branch back into this one.

if that makes sense.

[Pirulax]

Actually i could just go to another branch, squash merge the whole branch, and stage-commit changes line-by-line, so every commit would be perfect.

If theres a way to merge without having a 'merged branch..' commit automatically added?

[Pirulax]

Im not quite sure whats up with the new parser?
Please take a look at the build logs

[Pirulax]

All refactors have been moved to other PRs.